refactor!: Introduce IBrowserPool interface and utilize it in BrowserCrawler#3669
Open
janbuchar wants to merge 3 commits into
Open
refactor!: Introduce IBrowserPool interface and utilize it in BrowserCrawler#3669janbuchar wants to merge 3 commits into
janbuchar wants to merge 3 commits into
Conversation
janbuchar
added
adhoc
barjin
reviewed
May 22, 2026
Member
barjin
left a comment
barjin
left a comment
There was a problem hiding this comment.
Thank you @janbuchar, for driving this forward 🙌
I generally like the direction this is going, I'd be even stricter about the abstraction in the IBrowserPool interface ⬇️ Wdyt?
B4nan
reviewed
May 27, 2026
…crawling context)
janbuchar
commented
May 28, 2026
Contributor
Author
janbuchar
commented
May 28, 2026
| * an implementation detail used internally for cookie injection and by | ||
| * subclasses that need direct controller access (e.g. StagehandCrawler). | ||
| */ | ||
| protected _getBrowserControllerByPage(page: Page): ProvidedController | undefined { |
Contributor
Author
There was a problem hiding this comment.
Left here for https://github.com/apify/crawlee/pull/3669/changes#r3319371997 and StagehandCrawler. After we get rid of these dependencies, we can probably remove this, and the ProvidedController type parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SessionPoolinterface, minimizeISession, allow custom implementations #3644IBrowserPoolimplementation for remote browser services